Messages in this thread | | | Subject | Re: [PATCH] Add support for Yamaha AICA sound on SEGA Dreamcast | From | Adrian McMenamin <> | Date | Mon, 05 Jun 2006 10:59:32 +0100 |
| |
On Mon, 2006-06-05 at 12:53 +0300, Paul Mundt wrote:
> > +static void spu_init(void) > > This can probably be inlined.. > > > +/* aica_chn_start - write to spu to start playback */ > > +static void aica_chn_start(void) > > +{ > > + spu_write_wait(); > > + writel(AICA_CMD_KICK | AICA_CMD_START, > > + (uint32_t *) AICA_CONTROL_POINT); > > +} > > + > > +/* aica_chn_halt - write to spu to halt playback */ > > +static void aica_chn_halt(void) > > +{ > > + spu_write_wait(); > > + writel(AICA_CMD_KICK | AICA_CMD_STOP, > > + (uint32_t *) AICA_CONTROL_POINT); > > +} > > + > These too. >
No point in inlining these as they all wait on a FIFO to clear - ie the benefit of inling will be tiny. I notice a stray inline still lurking from the code that can go...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |