Messages in this thread | | | Date | Mon, 5 Jun 2006 19:03:55 -0700 | From | "Randy.Dunlap" <> | Subject | Re: 2.6.17-rc5-mm3 |
| |
On Mon, 05 Jun 2006 20:54:51 -0500 Paul Fulghum wrote:
> Randy.Dunlap wrote: > > Those Kconfig + Makefiles are quite ugly to me. I would rather see > > SYNCLINK depend on HDLC rather than using some tricks to SELECT HDLC. > > And then it selects HDLC (and HDLC depends on WAN), but (in my case) > > WAN was not enabled, and doing "SELECT HDLC" did not enable WAN. > > > > Adding SELECT WAN and changing the hdlc (wan) Makefile to use > > obj-m or obj-y (it was ONLY obj-y for hdlc) fixes^W makes it build > > with no missing symbols. However, I'll also see about a fix > > that uses "depends on HDLC" instead of "selects HDLC". > > Generic HDLC support in the synclink drivers is optional. > Should the generic HDLC code be enabled even if it is not used? > > Some of our customers would scream if we started forcing > them to compile and load unused code.
OK, I'll try to allow for that.
> > Fix many missing hdlc_generic symbols when CONFIG_HDLC=m. > > When Selecting HDLC, also Select WAN. > > Fix Makefile to build for HDLC=y or HDLC=m. > > > > + select WAN if SYNCLINK_HDLC > > If this is the accepted approach, then synclink_cs should be added also. > (drivers/char/pcmcia)
It's not the desired approach AFAIK, but it may be the only reasonable one. I'm still testing alternatives, but you are welcome to take over and fix it. :)
> What about select WAN if HDLC instead? > Or does kbuild not propogate the reverse dependency? > (SYNCLINK_HDLC selects HDLC, HDLC selects WAN)
OK.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |