Messages in this thread | | | Date | Mon, 5 Jun 2006 15:13:11 +0200 | From | Johann Lombardi <> | Subject | Re: [UPDATE][12/24]ext3 enlarge blocksize |
| |
On Fri, May 26, 2006 at 06:00:32AM -0600, Andreas Dilger wrote: > On May 25, 2006 21:49 +0900, sho@tnes.nec.co.jp wrote: > > @@ -1463,11 +1463,17 @@ static int ext3_fill_super (struct super > > + if (blocksize > PAGE_SIZE) { > > + printk(KERN_ERR "EXT3-fs: cannot mount filesystem with " > > + "blocksize %u larger than PAGE_SIZE %u on %s\n", > > + blocksize, PAGE_SIZE, sb->s_id); > > + goto failed_mount; > > + } > > + > > if (blocksize < EXT3_MIN_BLOCK_SIZE || > > - blocksize > EXT3_MAX_BLOCK_SIZE) { > > + blocksize > EXT3_EXTENDED_MAX_BLOCK_SIZE) { > > We may as well just change EXT3_MAX_BLOCK_SIZE to be 65536, because no other > code uses this value. It is already 65536 in the e2fsprogs.
AFAICS, ext3_dir_entry_2->rec_len will overflow with a 64kB blocksize. Do you know how ext2 handles this?
Cheers,
Johann - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |