[lkml]   [2006]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] readahead: initial method - expected read size - fix fastcall
On Sun, 4 Jun 2006 15:34:15 +0800
Fengguang Wu <> wrote:

> Remove 'fastcall' directive for function readahead_close().
> It has drawn concerns from Andrew Morton.

Well. I think fastcall is ugly and vaguely silly. Now if we has a
really_really_fastcall then I'd like to use that!

> Now I have some benchmarks
> on it, and proved it as a _false_ optimization.

Sorry, I don't believe this will be measurable (and with CONFIG_REGPARM
it'll be a no-op).

But I'm always glad to see a fastcall disappear ;)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-06-04 11:10    [W:0.086 / U:8.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site