lkml.org 
[lkml]   [2006]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 4/4] Twofish cipher - x86_64 assembler
    Date
    On Sunday 04 June 2006 15:16, Joachim Fritschi wrote:
    > This patch adds the twofish x86_64 assembler routine.
    >
    > Changes since last version:
    > - The keysetup is now handled by the twofish_common.c (see patch 1 )
    > - The last round of the encrypt/decrypt routines where optimized saving 5
    > instructions.
    >
    > Correctness was verified with the tcrypt module and automated test scripts.

    Do you have some benchmark numbers that show that it's actually worth
    it?

    > +/* Defining a few register aliases for better reading */

    Maybe you can read it now better, but for everybody else it is extremly
    confusing. It would be better if you just used the original register names.

    -andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-04 22:13    [W:0.019 / U:30.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site