Messages in this thread | | | Date | Fri, 30 Jun 2006 22:36:30 +0200 | From | Johannes Stezenbach <> | Subject | Re: [v4l-dvb-maintainer] [PATCH] DVB Needs I2C Core |
| |
On Fri, Jun 30, 2006, Parag Warudkar wrote: > DVB seems to be using i2c ( i2c_transfer() mainly ) all over the place but > it is possible to build DVB without having I2C selected. This results in > undefined symbol i2c_transfer in DVB module. > > This patch makes I2C Core selected automatically if DVB is selected. > Is it the right thing to do?
No. There are DVB drivers which don't use I2C (e.g. some of the USB ones). dvb-core doesn't use I2C at all. I think most of the dependencies have been corrected in git already.
Johannes
> --- linux-2.6.17/drivers/media/dvb/Kconfig.orig 2006-06-30 00:15:13.000000000 -0400 > +++ linux-2.6.17/drivers/media/dvb/Kconfig 2006-06-30 00:10:15.000000000 -0400 > @@ -7,6 +7,7 @@ menu "Digital Video Broadcasting Devices > config DVB > bool "DVB For Linux" > depends on NET && INET > + select I2C > ---help--- > Support Digital Video Broadcasting hardware. Enable this if you > own a DVB adapter and want to use it or if you compile Linux for
> _______________________________________________ > v4l-dvb-maintainer mailing list > v4l-dvb-maintainer@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |