lkml.org 
[lkml]   [2006]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 10/17] 2.6.17.1 perfmon2 patch for review: PMU context switch
    From
    Date
    Stephane Eranian <eranian@frankl.hpl.hp.com> writes:

    > This patch contains the PMU context switch routines.

    Description/why/what etc. missing.

    <quick look>

    This is all unconditionally called at context switch?!??

    No way this can be merged. It needs to be zero cost for any process
    that doesn't use perfmon and even for those it probably needs
    some tuning.

    See my earlier mail on how to make it zero cost for i386/x86-64.

    Please don't submit such horrible code again.

    -Andi

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-30 14:29    [W:4.283 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site