Messages in this thread | | | Date | Sat, 03 Jun 2006 13:12:35 +0400 | From | Michael Tokarev <> | Subject | Re: [stable] [PATCH] sbp2: fix check of return value of hpsb_allocate_and_register_addrspace |
| |
Stefan Richter wrote: > Chris Wright wrote: >> * Stefan Richter (stefanr@s5r6.in-berlin.de) wrote: > .... >>> +++ linux-2.6.17-rc5/drivers/ieee1394/sbp2.c 2006-06-03 >>> 01:54:23.000000000 +0200 >>> @@ -845,7 +845,7 @@ static struct scsi_id_instance_data *sbp >>> &sbp2_highlevel, ud->ne->host, &sbp2_ops, >>> sizeof(struct sbp2_status_block), sizeof(quadlet_t), >>> 0x010000000000ULL, CSR1212_ALL_SPACE_END); >>> - if (!scsi_id->status_fifo_addr) { >>> + if (scsi_id->status_fifo_addr == ~0ULL) {
Umm. Can this ~0ULL constant be #define'd to something? It's way too simple to mis-read it as NULL (or ~NULL whatever).
I mean.. I looked at this change for quite some time, trying to figure a difference (!x vs x==NULL), and thinking what's '-0' (~ turned out to be quite similar to - in the font my thunderbird uses).
/mjt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |