lkml.org 
[lkml]   [2006]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch] fix smt nice lock contention and optimization
    Date
    On Saturday 03 June 2006 18:12, Chen, Kenneth W wrote:
    > Ingo Molnar wrote on Saturday, June 03, 2006 12:58 AM
    >
    > > * Con Kolivas <kernel@kolivas.org> wrote:
    > > > Could we make this neater with extra braces such as:
    > > >
    > > > for_each_domain(this_cpu, tmp) {
    > > > if (tmp->flags & SD_SHARE_CPUPOWER) {
    > > > sd = tmp;
    > > > break;
    > > > }
    > > > }
    > > >
    > > > and same for the other uses of for_each ? I know it's redundant but
    > > > it's neater IMO when there are multiple lines of code below it.
    > >
    > > yep, that's the preferred style when there are multiple lines below a
    > > loop.
    >
    > OK, thanks for the tips. Here is an incremental coding-style fix:

    Great!

    Thanks Chris, Nick and Ken for your input.

    Signed-off-by: Con Kolivas <kernel@kolivas.org>
    for both

    --
    -ck
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-03 10:20    [W:0.025 / U:30.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site