lkml.org 
[lkml]   [2006]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.17-mm4

    * Dave Jones <davej@redhat.com> wrote:

    > On Thu, Jun 29, 2006 at 10:39:33PM +0200, Michal Piotrowski wrote:
    >
    > > This looks very strange.
    > >
    > > BUG: unable to handle kernel paging request at virtual address 6b6b6c07
    >
    > Looks like a use after free.

    i'm too hunting use-after-free bugs - the ones fixed below fix certain
    crashes, but i'm still seeing a nasty one.

    the crash is independent on lockdep enabled or disabled. See:

    http://redhat.com/~mingo/misc/

    for the config and the crash.log.

    Ingo

    -----------------
    Subject: fix platform_device_put/del mishaps
    From: Ingo Molnar <mingo@elte.hu>

    this fixes drivers/char/pc8736x_gpio.c and drivers/char/scx200_gpio.c
    to use the platform_device_del/put ops correctly.

    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    drivers/char/pc8736x_gpio.c | 5 +++--
    drivers/char/scx200_gpio.c | 6 +++---
    2 files changed, 6 insertions(+), 5 deletions(-)

    Index: linux/drivers/char/pc8736x_gpio.c
    ===================================================================
    --- linux.orig/drivers/char/pc8736x_gpio.c
    +++ linux/drivers/char/pc8736x_gpio.c
    @@ -319,9 +319,10 @@ static int __init pc8736x_gpio_init(void
    return 0;

    undo_platform_dev_add:
    - platform_device_put(pdev);
    + platform_device_del(pdev);
    undo_platform_dev_alloc:
    - kfree(pdev);
    + platform_device_put(pdev);
    +
    return rc;
    }

    Index: linux/drivers/char/scx200_gpio.c
    ===================================================================
    --- linux.orig/drivers/char/scx200_gpio.c
    +++ linux/drivers/char/scx200_gpio.c
    @@ -126,9 +126,10 @@ static int __init scx200_gpio_init(void)
    undo_chrdev_region:
    unregister_chrdev_region(dev, num_pins);
    undo_platform_device_add:
    - platform_device_put(pdev);
    + platform_device_del(pdev);
    undo_malloc:
    - kfree(pdev);
    + platform_device_put(pdev);
    +
    return rc;
    }

    @@ -136,7 +137,6 @@ static void __exit scx200_gpio_cleanup(v
    {
    kfree(scx200_devices);
    unregister_chrdev_region(MKDEV(major, 0), num_pins);
    - platform_device_put(pdev);
    platform_device_unregister(pdev);
    /* kfree(pdev); */
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-06-29 23:17    [W:0.042 / U:28.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site