lkml.org 
[lkml]   [2006]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/13] SERIAL: PARPORT_SERIAL should depend on SERIAL_8250_PCI
    Chris Wright wrote at Tue, 20 Jun 2006 00:00:07 -0700:

    > -stable review patch. If anyone has any objections, please let us know.
    > ------------------
    > From: Russell King <rmk+lkml@arm.linux.org.uk>
    >
    > Since parport_serial uses symbols from 8250_pci, there should
    > be a dependency between the configuration symbols for these
    > two modules. Problem reported by Andrey Borzenkov
    >
    > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
    > Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    > ---
    > drivers/parport/Kconfig | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    > --- linux-2.6.16.21.orig/drivers/parport/Kconfig
    > +++ linux-2.6.16.21/drivers/parport/Kconfig
    > @@ -48,7 +48,7 @@ config PARPORT_PC
    >
    > config PARPORT_SERIAL
    > tristate "Multi-IO cards (parallel and serial)"
    > - depends on SERIAL_8250 && PARPORT_PC && PCI
    > + depends on SERIAL_8250_PCI && PARPORT_PC && PCI
    > help
    > This adds support for multi-IO PCI cards that have parallel and
    > serial ports. You should say Y or M here. If you say M, the module

    Hmm. I just found out that this patch makes our serial+parallel PCI cards unusable..
    because.. well.. because it effectively turns parport_serial OFF, without a way to
    select it either as a module or built-in. Because on 2.6.16, there's NO such
    config symbol - SERIAL_8250_PCI. Ie, the original Kconfig was right, but this
    change just broke (disabled) parport_serial module completely.

    In contrast, in 2.6.17 (as Andrey Borzenkov correctly pointed out), this change IS
    needed (see eg. http://lkml.org/lkml/2006/6/18/117).

    I've no idea how this patch slipped into 2.6.16 -stable queue in the first place... ;)

    Thanks.

    /mjt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-29 19:34    [W:0.035 / U:0.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site