Messages in this thread | | | Date | Thu, 29 Jun 2006 11:43:45 -0400 (EDT) | From | James Morris <> | Subject | Re: [PATCH 1/3] SELinux: Extend task_kill hook to handle signals sent by AIO completion |
| |
On Thu, 29 Jun 2006, Stephen Smalley wrote:
> On Wed, 2006-06-28 at 17:16 -0700, Chris Wright wrote: > > > + void (*task_getsecid) (struct task_struct * p, u32 * secid); > > > > Why not just: > > u32 (*task_getsecid) (struct task_struct *p); > > That's fine, although we should then change the SELinux exports as well > to be consistent (and convert them all to secid rather than sid or > ctxid, and eliminate duplication there that has crept in). That can be > done by later patch.
My preference is to leave it as-is, because these interfaces generally return only error values. IMHO, it's always much clearer that way in any case, for APIs like this.
- James -- James Morris <jmorris@namei.org> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |