lkml.org 
[lkml]   [2006]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Documentation: remove duplicate cleanups
From
Date
On Thu, 29 Jun 2006 15:11:55 +0200, Paolo Ornati said:

> - matches the field we filled in in the struct
> + matches the field we filled in the struct
> video_device when registering.</entry>
> ------------
>
> I'm not 100% sure of this.

Both are technically correct. The original should be parsed (the field we
filled in) (in the struct). The revision changes it to 'the field we filled'.
Probably should change, just to avoid 'Paris in the the spring' effects...

> Note that ALL kernel parameters listed below are CASE SENSITIVE, and that
> -a trailing = on the name of any parameter states that that parameter will
> +a trailing = on the name of any parameter states that parameter will

> The old one looks correct.

Again, both are technically correct, but the change should be made...

> -caches are expected to be coherent, there's no guarantee that that coherency
> +caches are expected to be coherent, there's no guarantee that coherency
> will be ordered. This means that whilst changes made on one CPU will

> Not sure.

Again, should change, unless we want to emphasize "that *THAT* coherency
will be ordered" (as opposed to some other concurrenly applicable coherency).

> The driver is not real good at the moment for finding the card. You can
> 'help' it by changing the order of the potential addresses in the structure
> -found in the pt_init() function so the address of where the card is is put
> +found in the pt_init() function so the address of where the card is put
> first.

> The old one looks correct.

Only by virtue of incredibly poor sentence structure originally.

"so the address of the card is put first." would be simpler and better.


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-06-29 15:52    [W:0.052 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site