lkml.org 
[lkml]   [2006]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm patch] kernel/rcutorture.c: make code static
On Wed, Jun 28, 2006 at 06:54:45PM +0200, Adrian Bunk wrote:
> This patch makes needlessly global code static.

Looks good to me -- but have you tested it? If so, I will ack, otherwise
I will test and ack/nack depending on the results.

Thanx, Paul

> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> kernel/rcutorture.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> --- linux-2.6.17-mm3-full/kernel/rcutorture.c.old 2006-06-27 17:59:20.000000000 +0200
> +++ linux-2.6.17-mm3-full/kernel/rcutorture.c 2006-06-27 18:01:00.000000000 +0200
> @@ -105,11 +105,11 @@
> static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], rcu_torture_batch) =
> { 0 };
> static atomic_t rcu_torture_wcount[RCU_TORTURE_PIPE_LEN + 1];
> -atomic_t n_rcu_torture_alloc;
> -atomic_t n_rcu_torture_alloc_fail;
> -atomic_t n_rcu_torture_free;
> -atomic_t n_rcu_torture_mberror;
> -atomic_t n_rcu_torture_error;
> +static atomic_t n_rcu_torture_alloc;
> +static atomic_t n_rcu_torture_alloc_fail;
> +static atomic_t n_rcu_torture_free;
> +static atomic_t n_rcu_torture_mberror;
> +static atomic_t n_rcu_torture_error;
>
> /*
> * Allocate an element from the rcu_tortures pool.
> @@ -338,7 +338,7 @@
> }
> }
>
> -int srcu_torture_stats(char *page)
> +static int srcu_torture_stats(char *page)
> {
> int cnt = 0;
> int cpu;
> @@ -567,7 +567,7 @@
> /* Shuffle tasks such that we allow @rcu_idle_cpu to become idle. A special case
> * is when @rcu_idle_cpu = -1, when we allow the tasks to run on all CPUs.
> */
> -void rcu_torture_shuffle_tasks(void)
> +static void rcu_torture_shuffle_tasks(void)
> {
> cpumask_t tmp_mask = CPU_MASK_ALL;
> int i;
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-28 19:15    [W:0.167 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site