Messages in this thread | | | Date | Tue, 27 Jun 2006 09:51:27 -0700 | From | "Randy.Dunlap" <> | Subject | Re: [Linux-fbdev-devel] [PATCH, trivial] Remove about 50 unneeded #includes in fbdev |
| |
On Tue, 27 Jun 2006 12:19:07 -0400 Jon Smirl wrote:
> Remove about 50 unneeded #includes in fbdev
Does this that (a) these drivers build without these header files explicitly #included or (b) these drivers don't use *any* APIs or data from these header files?
They may build (a) but still use the APIs, so (b) is the requirement/target. (I.e., other header files could suck in the required headers.)
> Signed-off-by: Jon Smirl <jonsmirl@gmail.com> > > diff --git a/drivers/video/aty/aty128fb.c b/drivers/video/aty/aty128fb.c > index db878fd..e498a54 100644 > --- a/drivers/video/aty/aty128fb.c > +++ b/drivers/video/aty/aty128fb.c > @@ -46,26 +46,14 @@ > */ > > > -#include <linux/config.h> > #include <linux/module.h> > #include <linux/moduleparam.h> > -#include <linux/kernel.h> > #include <linux/errno.h> > -#include <linux/string.h> > -#include <linux/mm.h> > -#include <linux/tty.h> > -#include <linux/slab.h> > -#include <linux/vmalloc.h> > #include <linux/delay.h> > -#include <linux/interrupt.h> > #include <asm/uaccess.h> > #include <linux/fb.h> > -#include <linux/init.h> > #include <linux/pci.h> > -#include <linux/ioport.h> > #include <linux/console.h> > -#include <linux/backlight.h> > -#include <asm/io.h> > > #ifdef CONFIG_PPC_PMAC > #include <asm/machdep.h> > diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c > index c5185f7..5f4c76c 100644 > --- a/drivers/video/aty/atyfb_base.c > +++ b/drivers/video/aty/atyfb_base.c > @@ -49,26 +49,13 @@ > ******************************************************************************/ > > > -#include <linux/config.h> > -#include <linux/module.h> > -#include <linux/moduleparam.h> > -#include <linux/kernel.h> > -#include <linux/errno.h> > -#include <linux/string.h> > -#include <linux/mm.h> > -#include <linux/slab.h> > -#include <linux/vmalloc.h> > #include <linux/delay.h> > #include <linux/console.h> > #include <linux/fb.h> > -#include <linux/init.h> > #include <linux/pci.h> > #include <linux/interrupt.h> > -#include <linux/spinlock.h> > -#include <linux/wait.h> > #include <linux/backlight.h> > > -#include <asm/io.h> > #include <asm/uaccess.h> > > #include <video/mach64.h> > diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c > index c5ecbb0..56445ea 100644 > --- a/drivers/video/aty/radeon_base.c > +++ b/drivers/video/aty/radeon_base.c > @@ -52,25 +52,6 @@ > > #define RADEON_VERSION "0.2.0" > > -#include <linux/config.h> > -#include <linux/module.h> > -#include <linux/moduleparam.h> > -#include <linux/kernel.h> > -#include <linux/errno.h> > -#include <linux/string.h> > -#include <linux/mm.h> > -#include <linux/tty.h> > -#include <linux/slab.h> > -#include <linux/delay.h> > -#include <linux/time.h> > -#include <linux/fb.h> > -#include <linux/ioport.h> > -#include <linux/init.h> > -#include <linux/pci.h> > -#include <linux/vmalloc.h> > -#include <linux/device.h> > - > -#include <asm/io.h> > #include <asm/uaccess.h> > > #ifdef CONFIG_PPC_OF > diff --git a/drivers/video/aty/radeon_i2c.c b/drivers/video/aty/radeon_i2c.c > index a9d0414..4855c0a 100644 > --- a/drivers/video/aty/radeon_i2c.c > +++ b/drivers/video/aty/radeon_i2c.c > @@ -1,9 +1,3 @@ > -#include <linux/config.h> > -#include <linux/module.h> > -#include <linux/kernel.h> > -#include <linux/sched.h> > -#include <linux/delay.h> > -#include <linux/pci.h> > #include <linux/fb.h> > > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Linux-fbdev-devel mailing list > Linux-fbdev-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel >
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |