lkml.org 
[lkml]   [2006]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 27/61] lock validator: prove spinlock/rwlock locking correctness

* Andrew Morton <akpm@osdl.org> wrote:

> On Mon, 29 May 2006 23:25:23 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
>
> > +# define spin_lock_init_key(lock, key) \
> > + __spin_lock_init((lock), #lock, key)
>
> erk. This adds a whole new layer of obfuscation on top of the
> existing spinlock header files. You already need to run the
> preprocessor and disassembler to even work out which flavour you're
> presently using.
>
> Ho hum.

agreed. I think the API we started using in latest -mm
(lockdep_init_key()) is the cleaner approach - that also makes it
trivially sure that lockdep doesnt impact non-lockdep code. I'll fix the
current lockdep_init_key() shortcomings and i'll get rid of the
*_init_key() APIs.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-23 12:51    [W:0.222 / U:10.656 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site