Messages in this thread | | | Date | Thu, 22 Jun 2006 12:52:12 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [PATCH 4/4] Slab Reclaim logic |
| |
On Thu, 22 Jun 2006, Pekka J Enberg wrote:
> On Thu, 22 Jun 2006, Christoph Lameter wrote: > > > Please use struct kmem_cache instead of the typedef. Better name for l3 > > > would be nice. > > > > l3 is a very good name. > > No, it's a terrible name :-). But I guess it's ok for this patch.
Its a good name and you better come up with a another reason than "terrible name" before you change the established variable name in the slab allocator. Otherwise lots of us will have trouble reading the code.
Please make sure that all references to kmem_list3 are called consistently l3 thoughout the slab allocator.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |