lkml.org 
[lkml]   [2006]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] Slab Reclaim logic
On Thu, 22 Jun 2006, Christoph Lameter wrote:
> > s/nr_freed/ret/
>
> ret is non descriptive. nr_freed is describing what the purpose of the
> variable is.
>
> > > + while (nr_freed < slabs_to_free) {
> > > + int x;
> >
> > s/x/nr_freed/
>
> Would shadow variable.

Which is why I suggested using ret for the return variable. Not a biggie,
though, obviously.

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-22 21:49    [W:0.044 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site