lkml.org 
[lkml]   [2006]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] Slab Reclaim logic
On Mon, 19 Jun 2006, Christoph Lameter wrote:
> Add kmem_cache_reclaim() function.
>
> This patch adds the new slab reclaim functionalty. For that purpose we add a
> new function:
>
> long kmem_cache_reclaim(struct kmem_cache *cache, unsigned long nr_pages)

Some coding style comments below.

> +extern long kmem_cache_reclaim(struct kmem_cache *, gfp_t flags, unsigned long);

The parameter name is redundant.

> +static int try_reclaim_one(kmem_cache_t *cachep, struct kmem_list3 *l3,
> + struct list_head *list, unsigned short marker)

Please use struct kmem_cache instead of the typedef. Better name for l3
would be nice.

> +static int reclaim_scan(kmem_cache_t *cachep, struct kmem_list3 *l3,
> + int slabs_to_free, struct list_head *list, unsigned short marker)

Ditto.

> +{
> + int nr_freed = 0;

s/nr_freed/ret/

> +
> + while (nr_freed < slabs_to_free) {
> + int x;

s/x/nr_freed/

> +
> + x = try_reclaim_one(cachep, l3, list, marker);
> + if (x > 0)
> + nr_freed += x;
> + else
> + break;
> + }
> + return nr_freed;
> +}

> +long kmem_cache_reclaim(kmem_cache_t *cachep, gfp_t flags, unsigned long pages)
> +{

Typedef.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-22 21:44    [W:0.330 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site