lkml.org 
[lkml]   [2006]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm 6/6] cpu_relax(): ptrace.c coding style fix
Hi!

> Fix existing cpu_relax() loop to have proper kernel style.

..but you change the code, not its style.

> @@ -182,9 +182,8 @@
> if (!write_trylock(&tasklist_lock)) {
> local_irq_enable();
> task_unlock(task);
> - do {
> + while (!write_can_lock(&tasklist_lock))
> cpu_relax();
> - } while (!write_can_lock(&tasklist_lock));
> goto repeat;
> }

I guess that barrier was needed before write_can_lock can succeed.
=> your version does one unneccessary test.

--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-22 21:08    [from the cache]
©2003-2011 Jasper Spaans