Messages in this thread | | | Date | Thu, 22 Jun 2006 09:32:23 -0500 | From | Nathan Lynch <> | Subject | Re: [PATCH -mm 6/6] cpu_relax(): ptrace.c coding style fix |
| |
Andreas Mohr wrote: > > Fix existing cpu_relax() loop to have proper kernel style. >
...
> @@ -182,9 +182,8 @@ > if (!write_trylock(&tasklist_lock)) { > local_irq_enable(); > task_unlock(task); > - do { > + while (!write_can_lock(&tasklist_lock)) > cpu_relax(); > - } while (!write_can_lock(&tasklist_lock));
This is a change in behavior, not just style. (And there is nothing wrong with the current style.)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |