Messages in this thread | | | From | Herbert Xu <> | Subject | Re: Possible leaks in network drivers | Date | Thu, 22 Jun 2006 11:41:52 +1000 |
| |
Eric Sesterhenn <snakebyte@gmx.de> wrote: > > So something like this would be the correct fix for the example? > > Fix skb leak found by coverity checker (id #628), skb_put() might > return a new skb, which gets never freed when we return with > NETDEV_TX_BUSY. This patch moves the check above the skb_put().
This is bogus. NETDEV_TX_BUSY is meant to requeue the skb. The real problem is that copying the skb is simply wrong.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |