lkml.org 
[lkml]   [2006]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] Decouple IRQ issues (fix i386 compile issues)
    Date
    Rajesh Shah <rajesh.shah@intel.com> writes:

    > On Tue, Jun 20, 2006 at 04:24:35PM -0600, Eric W. Biederman wrote:
    >>
    >> The primary aim of this patch is to remove maintenances problems caused
    >> by the irq infrastructure. The two big issues I address are an
    >> artificially small cap on the number of irqs, and that MSI assumes
    >> vector == irq. My primary focus is on x86_64 but I have touched
    >> other architectures where necessary to keep them from breaking.
    >>
    > The MSI portions of this patchset is similar to the MSI cleanup
    > I was working on. I'll drop my patchkit and instead comment on
    > the relevant patches in this kit.
    >
    > I got a couple of minor compile errors on i386 (kernel/io_apic.c).
    > I fixed them up by hand and the resulting kernel booted and
    > worked with MSI in the limited testing I've done so far.


    Somewhere in the final round of cleanups I missed these two
    one liners. This is what it takes to fix the i386 build.

    Eric

    diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c
    index 18a5c2a..3068cde 100644
    --- a/arch/i386/kernel/io_apic.c
    +++ b/arch/i386/kernel/io_apic.c
    @@ -1173,7 +1173,6 @@ next:
    if (current_vector >= FIRST_SYSTEM_VECTOR) {
    offset++;
    if (!(offset%8)) {
    - spin_unlock_irqrestore(&vector_lock, flags);
    return -ENOSPC;
    }
    current_vector = FIRST_DEVICE_VECTOR + offset;
    @@ -2460,7 +2459,7 @@ void destroy_irq(unsigned int irq)
    {
    unsigned long flags;

    - dynmic_irq_cleanup(irq);
    + dynamic_irq_cleanup(irq);

    spin_lock_irqsave(&vector_lock, flags);
    irq_vector[irq] = 0;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-06-21 16:14    [W:2.939 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site