lkml.org 
[lkml]   [2006]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm patch] binfmt_elf: fix checks for bad address
In-Reply-To: <20060619222512.58ba3e48.akpm@osdl.org>

On Mon, 19 Jun 2006 22:25:12 -0700, Andrew Morton wrote:

> On Tue, 20 Jun 2006 00:55:24 -0400
> Chuck Ebbert <76306.1226@compuserve.com> wrote:
>
> > -#define BAD_ADDR(x) ((unsigned long)(x) > TASK_SIZE)
> > +#define BAD_ADDR(x) ((unsigned long)(x) >= TASK_SIZE)
>
> Convince us that this is correct for all the other users of BAD_ADDR() in
> this file.

Can I just wave my arms while asserting it's obvious? It seemed that
way to me...

There are two more logical pieces to that patch in RHEL4 but those I
really didn't understand enough to post. Who's the binfmt_elf expert?

--
Chuck
"You can't read a newspaper if you can't read." --George W. Bush
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-21 14:34    [W:0.046 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site