lkml.org 
[lkml]   [2006]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch -mm 20/20 RFC] chardev: GPIO for SCx200 & PC-8736x: add sysfs-GPIO interface
Jim Cromie <jim.cromie@gmail.com> wrote:
>
> Heres a better version

Well..

***************
*** 312,317 ****
}

pc8736x_init_shadow();
return 0;
}

--- 422,428 ----
}

pc8736x_init_shadow();
+ pc8736x_sysfs_init(&pdev->dev);
return 0;
}

I don't know how to fix that - pc8736x_gpio_init() doesn't call
pc8736x_init_shadow().

Plus the patch you sent still has spaces all over the place where we should
have tabs. You can fix that by editing the diff, search for "^+ ".

So I'll drop this patch altogether. Which is probably for the best at this
stage, because we're expecting a pile of teeny fixes from you agaisnt the
other 19 patches as a result of review comments (yes?)

Once all that has landed we can look at the sysfs-GPIO interface.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-21 02:12    [W:0.151 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site