[lkml]   [2006]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 06/13] tmpfs: time granularity fix for [acm]time going backwards
    -stable review patch.  If anyone has any objections, please let us know.

    From: Robin H. Johnson <>

    I noticed a strange behavior in a tmpfs file system the other day, while
    building packages - occasionally, and seemingly at random, make decided to
    rebuild a target. However, only on tmpfs.

    A file would be created, and if checked, it had a sub-second timestamp.
    However, after an utimes related call where sub-seconds should be set, they
    were zeroed instead. In the case that a file was created, and utimes(...,NULL)
    was used on it in the same second, the timestamp on the file moved backwards.

    After some digging, I found that this was being caused by tmpfs not having a
    time granularity set, thus inheriting the default 1 second granularity.

    Hugh adds: yes, we missed tmpfs when the s_time_gran mods went into 2.6.11.
    Unfortunately, the granularity of CURRENT_TIME, often used in filesystems,
    does not match the default granularity set by alloc_super. A few more such
    discrepancies have been found, but this is the most important to fix now.

    Signed-off-by: Robin H. Johnson <>
    Acked-by: Andi Kleen <>
    Signed-off-by: Hugh Dickins <>
    Signed-off-by: Chris Wright <>
    Signed-off-by: Greg Kroah-Hartman <>
    mm/shmem.c | 1 +
    1 file changed, 1 insertion(+)

    --- linux-
    +++ linux-
    @@ -2100,6 +2100,7 @@ static int shmem_fill_super(struct super
    sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
    sb->s_magic = TMPFS_MAGIC;
    sb->s_op = &shmem_ops;
    + sb->s_time_gran = 1;

    inode = shmem_get_inode(sb, S_IFDIR | mode, 0);
    if (!inode)
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-06-20 13:54    [W:0.037 / U:18.404 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site