lkml.org 
[lkml]   [2006]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cramfs corruption after BLKFLSBUF on loop device
 On Fri, Jun 02, Andrew Morton wrote:

> On Fri, 2 Jun 2006 10:43:27 +0200
> Olaf Hering <olh@suse.de> wrote:
>
> > On Thu, Jun 01, Andrew Morton wrote:
> >
> >
> > > > Do you want it like that?
> > > >
> > > > lock_page(page);
> > > > if (PageUptodate(page)) {
> > > > SetPageDirty(page);
> > > > mb();
> > > > return page;
> > > > }
> > >
> > > Not really ;) It's hacky. It'd be better to take a lock.
> >
> > Which lock exactly?
>
> Ah, sorry, there isn't such a lock. I was just carrying on.
>
> > I'm not sure how to proceed from here.
>
> I'd suggest you run SetPagePrivate() and SetPageChecked() on the locked
> page and implement a_ops.releasepage(), which will fail if PageChecked(),
> and will succeed otherwise:

No leak without tweaking PG_private.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-02 21:39    [W:0.092 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site