lkml.org 
[lkml]   [2006]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 11/20] spufs: use kzalloc in create_spu
    From: Jeremy Kerr <jk@ozlabs.org>

    Clean up create_spu() a little by using kzalloc instead of kmalloc +
    assignments.

    Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
    Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>

    ---

    arch/powerpc/platforms/cell/spu_base.c | 17 +----------------
    1 file changed, 1 insertion(+), 16 deletions(-)

    Index: powerpc.git/arch/powerpc/platforms/cell/spu_base.c
    ===================================================================
    --- powerpc.git.orig/arch/powerpc/platforms/cell/spu_base.c
    +++ powerpc.git/arch/powerpc/platforms/cell/spu_base.c
    @@ -701,7 +701,7 @@ static int __init create_spu(struct devi
    static int number;

    ret = -ENOMEM;
    - spu = kmalloc(sizeof (*spu), GFP_KERNEL);
    + spu = kzalloc(sizeof (*spu), GFP_KERNEL);
    if (!spu)
    goto out;

    @@ -713,28 +713,11 @@ static int __init create_spu(struct devi
    spu->nid = of_node_to_nid(spe);
    if (spu->nid == -1)
    spu->nid = 0;
    -
    - spu->stop_code = 0;
    - spu->slb_replace = 0;
    - spu->mm = NULL;
    - spu->ctx = NULL;
    - spu->rq = NULL;
    - spu->pid = 0;
    - spu->class_0_pending = 0;
    - spu->flags = 0UL;
    - spu->dar = 0UL;
    - spu->dsisr = 0UL;
    spin_lock_init(&spu->register_lock);
    -
    spu_mfc_sdr_set(spu, mfspr(SPRN_SDR1));
    spu_mfc_sr1_set(spu, 0x33);
    -
    - spu->ibox_callback = NULL;
    - spu->wbox_callback = NULL;
    - spu->stop_callback = NULL;
    - spu->mfc_callback = NULL;
    -
    mutex_lock(&spu_mutex);
    +
    spu->number = number++;
    ret = spu_request_irqs(spu);
    if (ret)
    --

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-19 20:46    [W:0.025 / U:0.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site