lkml.org 
[lkml]   [2006]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] [PATCH 4/8] inode-diet: Move i_cdev into a union

>===================================================================
>--- linux-2.6.17.orig/fs/file_table.c 2006-06-18 19:37:14.000000000 -0400
>+++ linux-2.6.17/fs/file_table.c 2006-06-18 19:50:56.000000000 -0400
>@@ -170,7 +170,7 @@
> if (file->f_op && file->f_op->release)
> file->f_op->release(inode, file);
> security_file_free(file);
>- if (unlikely(inode->i_cdev != NULL))
>+ if (unlikely(S_ISCHR(inode->i_mode) && (inode->i_cdev != NULL)))

Am I allowed to be nitpicky? If so, drop the () around inode->i_cdev !=
NULL. :)



Jan Engelhardt
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-19 19:23    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog