Messages in this thread | | | Date | Fri, 16 Jun 2006 07:45:32 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] fix cdrom open |
| |
On Fri, Jun 16 2006, Stephen Rothwell wrote: > Hi Jens, > > Some time ago the cdrom open routine was changed so that we call the > driver's open routine before checking to see if it is read only. However, > if we discovered that a read write open was not possible and the open > flags required a writable open, we just returned -EROFS without calling > the driver's release routine. This seems to work for most cdrom drivers, > but breaks the Powerpc iSeries virtual cdrom rather badly. The following > patch just inserts the release call in the error path. > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > > It would be good is this could go into 2.6.17 as it affects the new distro > kernels.
Looks good, I'll forward it for 2.6.17 inclusion.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |