lkml.org 
[lkml]   [2006]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] affs_fill_super() %s abuses
Hi,

On Thu, 15 Jun 2006, Al Viro wrote:

> @@ -420,11 +422,17 @@ got_root:
> }
>
> if (mount_flags & SF_VERBOSE) {
> - chksum = cpu_to_be32(chksum);
> - printk(KERN_NOTICE "AFFS: Mounting volume \"%*s\": Type=%.3s\\%c, Blocksize=%d\n",
> - AFFS_ROOT_TAIL(sb, root_bh)->disk_name[0],
> - AFFS_ROOT_TAIL(sb, root_bh)->disk_name + 1,
> - (char *)&chksum,((char *)&chksum)[3] + '0',blocksize);
> + int len = AFFS_ROOT_TAIL(sb, root_bh)->disk_name[0];
> + char name[32];
> +
> + if (len > 31)
> + len = 31;

You get the same effect by changing it above into "min(AFFS_ROOT_TAIL(sb,
root_bh)->disk_name[0], 31)" and makes the copying unnecessary.
BTW since this is only active with SF_VERBOSE, I don't think it's critical
enough for 2.6.17 at this point.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-15 14:33    [W:0.393 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site