lkml.org 
[lkml]   [2006]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/11] Task watchers: Register per-task delay accounting task watcher



Matt Helsley wrote:

>Adapts delayacct to use Task Watchers. Does not adapt taskstats to use Task
>Watchers.
>
>Signed-off-by: Matt Helsley <matthltc@us.ibm.com>
>Cc: Shailabh Nagar <nagar@watson.ibm.com>
>Cc: Balbir Singh <balbir@in.ibm.com>
>Cc: Chandra S. Seetharaman <sekharan@us.ibm.com>
>--
>
> include/linux/delayacct.h | 2 +-
> kernel/delayacct.c | 23 +++++++++++++++++++++++
> kernel/exit.c | 2 --
> kernel/fork.c | 2 --
> 4 files changed, 24 insertions(+), 5 deletions(-)
>
>
>
>
<snip>

>Index: linux-2.6.17-rc5-mm2/include/linux/delayacct.h
>===================================================================
>--- linux-2.6.17-rc5-mm2.orig/include/linux/delayacct.h
>+++ linux-2.6.17-rc5-mm2/include/linux/delayacct.h
>@@ -59,11 +59,11 @@ static inline void delayacct_tsk_init(st
> __delayacct_tsk_init(tsk);
> }
>
> static inline void delayacct_tsk_exit(struct task_struct *tsk)
> {
>- if (tsk->delays)
>+ if (unlikely(tsk->delays))
> __delayacct_tsk_exit(tsk);
> }
>
>

This snippet does not belong to this patchset...since the same check
(for tsk->delays) is
being used elsewhere in the delay accounting code, changes to use of
likely/unlikely should
be done elsewhere too, if deemed necesssary.

Otherwise patch looks good though I've not tested whether delay
accounting works unaffected
(don't see any reason why it shouldn't).


--Shailabh


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-14 05:34    [W:0.073 / U:1.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site