lkml.org 
[lkml]   [2006]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Lse-tech] [PATCH 04/11] Task watchers: Make process events configurable as a module
From
Date
On Tue, 2006-06-13 at 19:54 -0500, Chase Venters wrote:
> On Tuesday 13 June 2006 18:54, Matt Helsley wrote:
>
> > +static void cn_proc_fini(void)
> > +{
> > + int err;
> > +
> > + err = unregister_task_watcher(&cn_proc_nb);
> > + if (err != 0)
> > + printk(KERN_WARNING
> > + "cn_proc failed to unregister its task notify block\n");
>
> How about if (err), or if (unregister_task_watcher(&cn_proc_nb))?

I don't see any worthwhile benefit to the former and I've seen feedback
that the latter is less readable.

> > + cn_del_callback(&cn_proc_event_id);
> > +}
> > +
> > module_init(cn_proc_init);
> > +module_exit(cn_proc_fini);
>
> Thanks,
> Chase


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-14 03:29    [W:0.026 / U:1.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site