lkml.org 
[lkml]   [2006]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tmpfs time granularity fix for [acm]time going backwards. Also VFS time granularity bug on creat(). (Repost, more content)
On Mon, 12 Jun 2006, Andi Kleen wrote:
> "Robin H. Johnson" <robbat2@gentoo.org> writes:
> >
> > This patch should probably be included for 2.6.17, despite how long the
> > bug has been around. It's a one-liner, with no side-effects.
>
> Agreed. Good catch.
>
> That was my bug when doing the conversion - but for my defense
> having file systems outside fs/* is error prone.

Yes. And my bug for not noticing your s_time_gran patch to the others.

> Can we perhaps move tmpfs or at least the fs parts of shmem.c
> into fs/ in the future? (the file is too big anyways)

The file is shamefully big, yes. I'd hate to move the swap entry
part of it out of mm/, but it might be a possibility to divide it up:
the filesystem entry points in fs/, the use of swap in mm/ - be nice
if all that could be under obj-$(CONFIG_SWAP) in the Makefile.

I did once embark on looking at it from a CONFIG_SWAP point of view;
but didn't get far before more urgent work intervened. And your
argument grows weaker, with filesystems spreading through drivers,
and even to arch (spufs).

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-12 21:56    [W:0.061 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site