Messages in this thread | | | From | Michael Buesch <> | Subject | Re: [PATCH] x86 built-in command line | Date | Mon, 12 Jun 2006 19:36:34 +0200 |
| |
On Monday 12 June 2006 19:12, H. Peter Anvin wrote: > > +#ifdef CONFIG_CMDLINE_BOOL > > + strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE); > > +#endif > > + > > /* Save unparsed command line copy for /proc/cmdline */ > > saved_command_line[COMMAND_LINE_SIZE-1] = '\0'; > > > > NAK. > > a. Please make the patch available for x86-64 as well as x86. The two > are coupled enough that they need to agree. > > b. This patch will override a user-provided command line if one > exists. This is the wrong behaviour; instead, the builtin command > line should only apply if no user-specified command line is present.
I would say a user supplied cmd line should be appended to the built-in cmd line.
-- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |