lkml.org 
[lkml]   [2006]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [2.6.17-rc6] Section mismatch in drivers/net/ne.o during modpost
    On Sat, 10 Jun 2006 22:38:00 +0200, Sam Ravnborg wrote:
    >> --- linux-2617-rc6.orig/drivers/net/ne.c
    >> +++ linux-2617-rc6/drivers/net/ne.c
    >> @@ -829,7 +829,7 @@ that the ne2k probe is the last 8390 bas
    >> is at boot) and so the probe will get confused by any other 8390 cards.
    >> ISA device autoprobes on a running machine are not recommended anyway. */
    >>
    >> -int init_module(void)
    >> +int __init init_module(void)
    >> {
    >> int this_dev, found = 0;
    >
    >When you anyway touches the driver I suggest to name the function
    ><module>_init, <module>_cleanup and use module_init(), module_cleanup().

    Maybe not: in the ne.c driver init_module() is inside #ifdef MODULE,
    so conversion to ne_init() + module_init(ne_init) would be a no-op
    except for making the code larger. In the non-MODULE case Space.c
    calls ne_probe() directly.

    /Mikael
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-11 16:40    [W:0.018 / U:59.772 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site