lkml.org 
[lkml]   [2006]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[Patch] Cyclades Cleanup
From
Date
hi,

coverity choked at two !tty checks, in places where tty can
never be NULL. Since it removes some code we should remove
these checks. (Coverity ids #763,#762)

Signed-off-by Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6.17-rc5/drivers/char/cyclades.c.orig 2006-06-11 23:11:35.000000000 +0200
+++ linux-2.6.17-rc5/drivers/char/cyclades.c 2006-06-11 23:11:55.000000000 +0200
@@ -2833,7 +2833,7 @@ cy_write(struct tty_struct * tty, const
return 0;
}

- if (!tty || !info->xmit_buf || !tmp_buf){
+ if (!info->xmit_buf || !tmp_buf){
return 0;
}

@@ -2884,7 +2884,7 @@ cy_put_char(struct tty_struct *tty, unsi
if (serial_paranoia_check(info, tty->name, "cy_put_char"))
return;

- if (!tty || !info->xmit_buf)
+ if (!info->xmit_buf)
return;

CY_LOCK(info, flags);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-11 23:17    [W:0.123 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site