lkml.org 
[lkml]   [2006]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kthread conversion: convert ieee1394 from kernel_thread
On Sat, 2006-06-10 at 16:42 +0100, Christoph Hellwig wrote:
> On Sat, Jun 10, 2006 at 05:11:42PM +0200, Stefan Richter wrote:
> > Serge, could you reduce your patch to the nodemgr part and resubmit?
>
> I'd prefer ieee1394 would just stop creating these thread entirely.
> Sure, rescaning the bus might take some time, but so do pci or especially
> scsi bus rescans. A user should expect his thread to block when he
> writes to an attribute caled rescan.

1394 bus rescanning takes a _lot_ longer than a PCI rescan. If we don't
do this in a kthread, then we have to do it as a tasklet, and take a
chance of stalling for a few seconds (not ms), preventing other
tasklet's from running. Suboptimal, IMO.

Also, neither PCI nor SCSI rescans occur quite as often as 1394 rescans.
It's more like USB (which also uses a kthread, or at least used to).

--
Ubuntu - http://www.ubuntu.com/
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
SwissDisk - http://www.swissdisk.com/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-10 18:37    [W:0.212 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site