Messages in this thread | | | Date | Mon, 8 May 2006 14:26:40 -0700 | From | Andrew Morton <> | Subject | Re: [Patch 3/8] cpu delay collection via schedstats |
| |
Balbir Singh <balbir@in.ibm.com> wrote: > > +/* > + * Expects runqueue lock to be held for atomicity of update > + */ > +static inline void rq_sched_info_arrive(struct runqueue *rq, > + unsigned long diff) > +{ > + if (rq) { > + rq->rq_sched_info.run_delay += diff; > + rq->rq_sched_info.pcnt++; > + } > +} > + > +/* > + * Expects runqueue lock to be held for atomicity of update > + */ > +static inline void rq_sched_info_depart(struct runqueue *rq, > + unsigned long diff) > +{ > + if (rq) > + rq->rq_sched_info.cpu_time += diff; > +}
The kernel has many different units of time - jiffies, cpu ticks, ns, us, ms, etc. So the reader of these functions doesn't have a clue what "diff" is.
A good way to remove all doubt in all cases is to include the units in the variable's name. Something like delta_jiffies, perhaps.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |