[lkml]   [2006]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 8/14] random: Remove SA_SAMPLE_RANDOM from USB gadget drivers
    On Sat, May 06, 2006 at 11:16:16AM -0700, David Brownell wrote:
    > On Saturday 06 May 2006 4:07 am, Denis Vlasenko wrote:
    > > On Friday 05 May 2006 19:42, Matt Mackall wrote:
    > > > Remove SA_SAMPLE_RANDOM from USB gadget drivers
    > It's conventional to post USB patches to linux-usb-devel, or at least
    > to CC that list.
    > > > There's no a priori reason to think that USB device interrupts will
    > > > contain "entropy" as defined/required by /dev/random. In fact, most
    > > > operations will be streaming and bandwidth- or CPU-limited.
    > > > /dev/random needs unpredictable inputs such as human interaction or
    > > > chaotic physical processes like turbulence manifested in disk seek
    > > > times.
    > And that'd be why you removed that SAMPLE_RANDOM from the Lubbock VBUS
    > irqs ... which come from users connecting (by hand!) a USB cable. :)

    Really I removed it because I want SAMPLE_RANDOM to go away and most
    of the users were either pretty trivial (the Lubbock case), wrong (a
    bunch of block devices, etc), or suspect (network, i2c).

    > You shouldn't add spaces before labels, or change indents from
    > pure-tab to tabs-plus-four-spaces.

    Show me where I did that, please.

    > Admittedly OMAP _now_ has access to the FIPS-certified hardware RNG,
    > so for that platform it's hard to justify needing other entropy sources.
    > But on the other hand, DMA completion IRQs aren't exactly predictable
    > either, and it doesn't necessarily hurt to salt a high entropy pool
    > with some less-high entropy inputs.

    The sampling is fine. It's the _accounting_ that's at issue.

    Mathematics is the supreme nostalgia of our time.
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-05-06 20:38    [W:0.020 / U:10.604 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site