Messages in this thread | | | From | Andi Kleen <> | Subject | Re: linux-2.6 x86_64 kgdb issue | Date | Wed, 31 May 2006 11:41:43 +0200 |
| |
> My bet is that in this case I was storing a LOT of > data in the thread structure, so the space left for > the stack was massively reduced.
Ok so it was your bug. Don't do that.
> Sure but the debugger environment must tolerate larger stacks.
No, Linux doesn't tolerate larger stacks.
> But this can miss a minor abuse. The interrupt check > is a quick and simple hack but I wonder if it's really > optimal for commercial implementations.
In practice if you overwrite thread_info you crash eventually and it's noticed. If you write below thread_info but keep ti intact then the redzone would likely not catch it either.
I don't think an additional red zone would improve overflow detection in a significant way.
> I think all modules should be ABLE to be built in.
If you have a working module it can be easily built in too. Just hacks that don't work with modules are bad.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |