lkml.org 
[lkml]   [2006]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectSome socket syscalls fail to return an error on bad file-descriptor# argument
Description:

The sockfd_lookup_light() function does not set the return error status
on a particular failure mode when the passed-in fd# is erroneous.

Environment:

2.6.16 kernel with the -mm2 patch-set applied. Linux 2.6.17 kernels are
also affected. Without the fix, a number of tests in LTP fail! Any
program calling one of the syscalls listed below with a bad fd# will not
get an error return indicating that the syscall failed.

Fix:

The attached patch correctly sets *err = -EBADF if the attempt to map
the fd# to a file pointer returns NULL. The following syscalls are
affected-

bind()
listen()
accept()
connect()
getsockname()
getpeername()
setsockopt()
setsockopt()
shutdown()
sendmsg()
recvmsg()



diff -urpN ./net/socket.c.orig ./net/socket.c
--- ./net/socket.c.orig 2006-06-01 10:28:30.000000000 +1000
+++ ./net/socket.c 2006-06-01 10:34:09.000000000 +1000
@@ -496,6 +496,8 @@ static struct socket *sockfd_lookup_ligh
if (sock)
return sock;
fput_light(file, *fput_needed);
+ } else {
+ *err = -EBADF;
}
return NULL;
}
\
 
 \ /
  Last update: 2006-06-01 05:41    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog