lkml.org 
[lkml]   [2006]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 12/12] input: use -ENOSPC instead of -ENOMEM in iforce when device full
    On Tue, 30 May 2006 13:57:17 +0300 Anssi Hannula wrote:

    > Use -ENOSPC instead of -ENOMEM when the iforce device doesn't have enough free
    > memory for the new effect. All other drivers are already been using -ENOSPC,
    > so this makes the behaviour coherent.

    Could all of the others be wrong?

    ENOSPC: No space left on device
    ENOMEM: Not enough space [!?!?!?] or Out of memory


    > Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>
    >
    > ---
    > drivers/input/joystick/iforce/iforce-ff.c | 8 ++++----
    > 1 files changed, 4 insertions(+), 4 deletions(-)
    >
    > Index: linux-2.6.17-rc4-git12/drivers/input/joystick/iforce/iforce-ff.c
    > ===================================================================
    > --- linux-2.6.17-rc4-git12.orig/drivers/input/joystick/iforce/iforce-ff.c 2006-05-26 16:55:12.000000000 +0300
    > +++ linux-2.6.17-rc4-git12/drivers/input/joystick/iforce/iforce-ff.c 2006-05-26 16:57:13.000000000 +0300
    > @@ -47,7 +47,7 @@ static int make_magnitude_modifier(struc
    > iforce->device_memory.start, iforce->device_memory.end, 2L,
    > NULL, NULL)) {
    > mutex_unlock(&iforce->mem_mutex);
    > - return -ENOMEM;
    > + return -ENOSPC;
    > }
    > mutex_unlock(&iforce->mem_mutex);
    > }
    > @@ -80,7 +80,7 @@ static int make_period_modifier(struct i
    > iforce->device_memory.start, iforce->device_memory.end, 2L,
    > NULL, NULL)) {
    > mutex_unlock(&iforce->mem_mutex);
    > - return -ENOMEM;
    > + return -ENOSPC;
    > }
    > mutex_unlock(&iforce->mem_mutex);
    > }
    > @@ -120,7 +120,7 @@ static int make_envelope_modifier(struct
    > iforce->device_memory.start, iforce->device_memory.end, 2L,
    > NULL, NULL)) {
    > mutex_unlock(&iforce->mem_mutex);
    > - return -ENOMEM;
    > + return -ENOSPC;
    > }
    > mutex_unlock(&iforce->mem_mutex);
    > }
    > @@ -157,7 +157,7 @@ static int make_condition_modifier(struc
    > iforce->device_memory.start, iforce->device_memory.end, 2L,
    > NULL, NULL)) {
    > mutex_unlock(&iforce->mem_mutex);
    > - return -ENOMEM;
    > + return -ENOSPC;
    > }
    > mutex_unlock(&iforce->mem_mutex);
    > }
    >
    > --


    ---
    ~Randy
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-31 07:02    [W:0.023 / U:0.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site