Messages in this thread | | | Date | Wed, 3 May 2006 17:55:02 +0100 | From | Al Viro <> | Subject | Re: [PATCH 11/14] Reworked patch for labels on user space messages |
| |
On Wed, May 03, 2006 at 10:52:36AM -0400, Stephen Smalley wrote: > On Wed, 2006-05-03 at 15:28 +0100, Al Viro wrote: > > On Wed, May 03, 2006 at 10:11:52AM -0400, Jon Smirl wrote: > > > Something seems to be wrong in selinux_get_task_sid. I am getting > > > thousands of these and can't boot the kernel. > > > > It's actually in security/selinux/hooks.c::selinux_disable() and gets > > triggered if you have selinux enabled and explicitly disable afterwards. > > Stephen Smalley had done a fix yesterday, basically adding > > selinux_enabled = 0; > > after > > selinux_disabled = 1; > > in there. selinux_get_task_sid() happens to step on that in visible way > > and nobody had caught that while this stuff was sitting in -mm ;-/ > > > > The only question I have about that patch: what would happen if we do not > > have CONFIG_SECURITY_SELINUX_BOOTPARAM? In that case selinux_enabled is > > defined to 1, so... > > Good point. Ok, take two. > > [patch 1/1] selinux: Clear selinux_enabled flag upon runtime disable. > > Clear selinux_enabled flag upon runtime disable of SELinux by userspace, > and make sure it is defined even if selinux= boot parameter support is > not enabled in configuration. > > Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: Al Viro <viro@zeniv.linux.org.uk> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |