| Date | Mon, 29 May 2006 18:33:41 -0700 | From | Andrew Morton <> | Subject | Re: [patch 11/61] lock validator: lockdep: small xfs init_rwsem() cleanup |
| |
On Mon, 29 May 2006 23:23:59 +0200 Ingo Molnar <mingo@elte.hu> wrote:
> nit_rwsem() has no return value. This is not a problem if init_rwsem() > is a function, but it's a problem if it's a do { ... } while (0) macro. > (which lockdep introduces) > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> > --- > fs/xfs/linux-2.6/mrlock.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux/fs/xfs/linux-2.6/mrlock.h > =================================================================== > --- linux.orig/fs/xfs/linux-2.6/mrlock.h > +++ linux/fs/xfs/linux-2.6/mrlock.h > @@ -28,7 +28,7 @@ typedef struct { > } mrlock_t; > > #define mrinit(mrp, name) \ > - ( (mrp)->mr_writer = 0, init_rwsem(&(mrp)->mr_lock) ) > + do { (mrp)->mr_writer = 0; init_rwsem(&(mrp)->mr_lock); } while (0) > #define mrlock_init(mrp, t,n,s) mrinit(mrp, n) > #define mrfree(mrp) do { } while (0) > #define mraccess(mrp) mraccessf(mrp, 0)
I'll queue this for mainline, via the XFS tree. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|