Messages in this thread | | | Subject | Re: [RFC]disable msi mode in pci_disable_device | From | Shaohua Li <> | Date | Mon, 29 May 2006 10:12:32 +0800 |
| |
On Fri, 2006-05-26 at 16:10 -0700, Rajesh Shah wrote: > On Fri, May 26, 2006 at 10:26:57PM +0200, Brice Goglin wrote: > > > > I just tried, the patch fixes our problem (no need to restore right > > after saving to reenable MSI). > > > Yeah, I agree this latest patch from Shaohua is the right thing, > and that pci save/restore msi state functions should not have > the side effect of disabling/enabling MSI. Shaohua, do drivers > already call pci_disable_device() or will you have to patch > them all to get the disable effect? I guess most drivers already do this. It's recommended way (call pci_disable_device in suspend) for a long time for suspend/resume. If they really care, the driver authors should fix them.
Thanks, Shaohua - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |