Messages in this thread | | | Date | Fri, 26 May 2006 17:56:22 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | [RFC][PATCH] ia64 node hotplug -- cpu - node relationship fix [0/2] intro |
| |
current -mm tree includes node-hotplug codes.
But by following reason , ia64's node-hotplug doesn't work well now.
Following patch will fix it. I'd like to post this patch against next -mm. Feedbacks are welcome.
1. empty-node-fix : avoid creating empty node SRAT's enable bit just shows 'you can read this entry'. But the kernel know this and checks each entries are vaild or not later.
But pxm_bit/node_online_mask is not treated as they should be. The kernel creates empty node, which has no cpu, no memory.
Becasue of the empty node, node-hot-added will not create new NODE_DATA at hotadd event. It's already created at boot time as empty node. I'm now thinking of allocate NODE_DATA on local (hot-added) node. So, avoiding to allocate empty NODE_DATA (allocated on off-node) is necessary.
My concern is whether there is a nice way to detect I/O only node at boot time or not. (if we need it) If someone shows it, I'll add it to my patch.
2. cpu-to-node fix: fix cpu-to-node mapping at cpu hotplug cpu hotplug on NUMA has to map cpu to its node. From its comment in the code, it expects the container hotplug will map pxm to correct node. But the container hotplug itself doesn't it now and acpi_map_pxm_to_node() is introduced. We also need to update node_to_cpu_mask[] and cpu_to_node_map[].
BTW, our team's node-hotplug considers (cpu + memory) hotplug by ACPI's container. Does anyone has plan of cpu-only-node-hotplug or I/O-only-node-hotplug ? If someone has, I'll develop memory-less-node hotplug, which just allocates NODE_DATA of hot-added node.
-Kame
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |