Messages in this thread | | | Subject | Re: [openib-general] [PATCH 06/16] ehca: interrupt handling routines | From | Roland Dreier <> | Date | Fri, 26 May 2006 13:06:44 -0700 |
| |
> + for_each_online_cpu(cpu) { > + task = create_comp_task(pool, cpu); > + if (task) { > + kthread_bind(task, cpu); > + wake_up_process(task); > + } > + }
How does this creation of a thread pool work with respect to CPU hotplug? What happens if a CPU goes away? How about if only one CPU is running when the driver is loaded, and then 15 more are hot-added?
> + for (i = 0; i < NR_CPUS; i++) { > + if (cpu_online(i)) > + destroy_comp_task(pool, i); > + }
And it seems in the destroy function, you will possibly leak threads or try to kill a non-existent thread if the set of online CPUs has changed since the driver started...
- R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |