Messages in this thread | | | Subject | Re: [Fastboot] [PATCH 01/03] kexec: Avoid overwriting the current pgd (V2, stubs) | From | (Eric W. Biederman) | Date | Wed, 24 May 2006 22:37:03 -0600 |
| |
Magnus Damm <magnus@valinux.co.jp> writes:
> On Wed, 2006-05-24 at 20:41 -0600, Eric W. Biederman wrote: >> Magnus Damm <magnus@valinux.co.jp> writes: >> >> > --===============059810052910035161== >> > >> > kexec: Avoid overwriting the current pgd (V2, stubs) >> > >> > This patch adds an architecture specific structure "struct kimage_arch" to >> > struct kimage. This structure is filled in with members by the architecture >> > specific patches followed by this one. >> >> You should be able to completely remove the need for this by simply >> adding a single additional external variable to the control code >> page. Given that you abuse this information and store way more >> than you need I am not persuaded that it is an interesting case. > > I'm sorry, but I do not understand. Care to explain a bit more, maybe > with some examples?
I believe I gave a complete explanation the first round.
By having an extra extern variable you can export the offset of a variable on the control code page, or what you need to compute the offset.
> Also, I get the impression that you dislike my patches. I'd like to work > with you and the community to merge my patches, but for that to happen > I'd appreciate if we both kept the language on a professional level.
Yes. I dislike your patches, but I don't dislike what you are trying to do.
Part of the reason is you do more than one thing at a time, which makes review much more difficult than it needs to be.
> Next time, please try to avoid strong words such as "abuse", "horrible" > and "ridiculous".
I call them as I see them, and probably if I am a little frustrated I may be a little more extreme. Usually I find that I have too much implied content and don't explain why I consider something abuse for example.
In the above quoted section I figure it is abuse to place what only needs to be an array of local variables in a global structure.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |