Messages in this thread Patch in this message |  | | Date | Wed, 24 May 2006 00:29:16 -0400 | | From | Florin Malita <> | | Subject | [PATCH] affs: possible null pointer dereference in affs_rename() |
| |
If affs_bread() fails, the exit path calls mark_buffer_dirty_inode() with a NULL argument.
Coverity CID: 312.
Signed-off-by: Florin Malita <fmalita@gmail.com> ---
diff --git a/fs/affs/namei.c b/fs/affs/namei.c index d4c2d63..a42143c 100644 --- a/fs/affs/namei.c +++ b/fs/affs/namei.c @@ -416,10 +416,9 @@ affs_rename(struct inode *old_dir, struc return retval; } - retval = -EIO; bh = affs_bread(sb, old_dentry->d_inode->i_ino); if (!bh) - goto done; + return -EIO; /* Remove header from its parent directory. */ affs_lock_dir(old_dir);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |